feat(vite-plugin-angular): fix .ts typechecking and add disableTypeChecking option #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattlewis92
commented
Jan 6, 2025
| if (disableTypeChecking) { | ||
| // Syntax errors are cheap to compute and the app will not run if there are any | ||
| // So always show these types of errors regardless if type checking is disabled | ||
| return syntacticDiagnostics; |
There was a problem hiding this comment.
This matches the behaviour of the angular cli where disabling typechecking only disables semantic diagnostics:
https://github.com/angular/angular-cli/blob/9b57ff0552736e6fef44c0ff7e6535f9ed832c6b/packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts#L378C90-L378C98
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ecking option Fixes analogjs#1532
brandonroberts
approved these changes
Jan 6, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes #1532
What is the new behavior?
Fixes typechecking of .ts files (implementation borrowed from the angular CLI). Currently only component templates are typechecked.
As this has the potential to impact performance, we also add a
disableTypeCheckingoption to disable typechecking completely (so that folks can runngc --noEmitto typecheck separately)Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?