fix(vite-plugin-angular): invalidation fixes for HMR/live reload (#1526)

analogjs · Dec 28, 2024 · 7b783d9 · 7b783d9
1 parent b3f8a93
commit 7b783d9
Showing 1 changed file with 23 additions and 1 deletion.
diff --git a/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts b/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts
@@ -277,8 +277,20 @@ export function angular(options?: PluginOptions): Plugin[] {
             }
 
             const [fileId] = decodeURIComponent(componentId).split('@');
-            const result = await fileEmitter?.(resolve(process.cwd(), fileId));
+            const resolvedId = resolve(process.cwd(), fileId);
+            const invalidated =
+              !!server.moduleGraph.getModuleById(resolvedId)
+                ?.lastInvalidationTimestamp;
+
+            // don't send an HMR update until the file has been invalidated
+            if (!invalidated) {
+              res.setHeader('Content-Type', 'text/javascript');
+              res.setHeader('Cache-Control', 'no-cache');
+              res.end('');
+              return;
+            }
 
+            const result = await fileEmitter?.(resolvedId);
             res.setHeader('Content-Type', 'text/javascript');
             res.setHeader('Cache-Control', 'no-cache');
             res.end(`${result?.hmrUpdateCode || ''}`);
@@ -336,6 +348,11 @@ export function angular(options?: PluginOptions): Plugin[] {
 
             return ctx.modules.map((mod) => {
               if (mod.id === ctx.file) {
+                // support Vite 6
+                if ('_clientModule' in mod) {
+                  (mod as any)['_clientModule'].isSelfAccepting = true;
+                }
+
                 return {
                   ...mod,
                   isSelfAccepting: true,
@@ -388,6 +405,11 @@ export function angular(options?: PluginOptions): Plugin[] {
 
             return ctx.modules.map((mod) => {
               if (mod.id === ctx.file) {
+                // support Vite 6
+                if ('_clientModule' in mod) {
+                  (mod as any)['_clientModule'].isSelfAccepting = true;
+                }
+
                 return {
                   ...mod,
                   isSelfAccepting: true,