Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maturin to build backend and build tools exceptions #311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add maturin to build backend and build tools exceptions #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4e9295
Add maturin to build backend and build tools exceptions
JeanChristopheMorinPerso Oct 30, 2023
912494f
Fix tests and format
JeanChristopheMorinPerso Oct 30, 2023
fc34e52
Merge branch 'main' into add_maturin_to_exceptions
JeanChristopheMorinPerso Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions anaconda_linter/lint/check_build_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"flit-core",
"hatch",
"hatchling",
"maturin",
"meson",
"meson-python",
"pdm",
Expand All @@ -64,6 +65,7 @@
"flit-core", # Backend of flit.
"hatch", # Same as flit, we should not depend on it. We should instead depend on hatchling, which is the backend.
"hatchling", # Backend of hatch.
"maturin", # Backend for bindings written in rust.
"meson-python", # Backend that uses meson.
"pdm-backend", # Backend of pdm (new). Not yet in our repo, but if it ever does, we'll be able to handle it.
"pdm-pep517", # Deprecated backend of pdm but we still need to support it, see https://pypi.org/project/pdm-pep517
Expand Down
22 changes: 11 additions & 11 deletions tests/test_build_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_host_section_needs_exact_pinnings_good(base_yaml):
+ """
requirements:
host:
- maturin 0.13.7
- example 0.13.7
"""
)
lint_check = "host_section_needs_exact_pinnings"
Expand All @@ -32,11 +32,11 @@ def test_host_section_needs_exact_pinnings_good_multi(base_yaml):
- name: output1
requirements:
host:
- maturin 0.13.7
- example 0.13.7
- name: output2
requirements:
host:
- maturin 0.13.7
- example 0.13.7
"""
)
lint_check = "host_section_needs_exact_pinnings"
Expand Down Expand Up @@ -86,11 +86,11 @@ def test_host_section_needs_exact_pinnings_good_cbc(base_yaml, recipe_dir):
+ """
requirements:
host:
- maturin
- example
"""
)
cbc = """
maturin:
example:
- 0.13.7
"""
cbc_file = recipe_dir / "conda_build_config.yaml"
Expand Down Expand Up @@ -128,15 +128,15 @@ def test_host_section_needs_exact_pinnings_good_cbc_multi(base_yaml, recipe_dir)
- name: output1
requirements:
host:
- maturin
- example
- name: output2
requirements:
host:
- maturin
- example
"""
)
cbc = """
maturin:
example:
- 0.13.7
"""
cbc_file = recipe_dir / "conda_build_config.yaml"
Expand All @@ -153,7 +153,7 @@ def test_host_section_needs_exact_pinnings_bad(base_yaml, constraint):
+ f"""
requirements:
host:
- maturin {constraint}
- example {constraint}
"""
)
lint_check = "host_section_needs_exact_pinnings"
Expand All @@ -170,11 +170,11 @@ def test_host_section_needs_exact_pinnings_bad_multi(base_yaml, constraint):
- name: output1
requirements:
host:
- maturin {constraint}
- example {constraint}
- name: output2
requirements:
host:
- maturin {constraint}
- example {constraint}
"""
)
lint_check = "host_section_needs_exact_pinnings"
Expand Down
Loading