fix failing test due to conda changes #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg1969
changed the title
mcg1969
force-pushed
the
testfix
branch
10 times, most recently
from
79b0415 to
e98dcc0
Compare
jezdez
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Sad to see these changes needed, but they were probably inevitable. I'll look into #62 next week if you agree that would be useful. For conda-libmamba-solver we follow that tactic and auto-create issues if the periodic tests fail.
| @@ -56,29 +54,39 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| cversion: ['4.11.0', '4.14.0', '23.7.3', '23.5.2', '23.3.1', '23.1.0', '22.11.1'] | |||
| cversion: ['4.11.0', '4.14.0', '22.11.1', '23.3.1', '23.7.3', '23.10.0', '24.1.2'] | |||
There was a problem hiding this comment.
That reminds me that we should maybe consider running the tests with the canary builds we create for conda on merging into main (but don't fail), I opened #62
Comment on lines
+98
to
+101
| # Unfortunately conda has evolved how it logs request headers | ||
| # So this regular expression attempts to match multiple forms | ||
| # > User-Agent: conda/... | ||
| # .... {'User-Agent': 'conda/...', ...} |
There was a problem hiding this comment.
Reminder to myself that this sounds like a plugin opportunity (been thinking about a general purpose logging plugin hook, to configure an own handler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_info_dictno longer takes an argument. We never needed to set it anyway, since we were passing its default value.local::channel seems to be different