fix(MSVC): Don't enforce /Zi if POLICY CMP0141 is available #264
Conversation
| ${_project_name} INTERFACE /fsanitize=${LIST_OF_SANITIZERS} /Zi /INCREMENTAL:NO | ||
| ${_project_name} INTERFACE /fsanitize=${LIST_OF_SANITIZERS} /INCREMENTAL:NO |
There was a problem hiding this comment.
Would this break the default sanitizer experience? We want the sanitizer to work by default in MSVC.
There was a problem hiding this comment.
I don't think so, from version 3.25 CMake sets MSVC_DEBUG_INFORMATION_FORMAT to $<$<CONFIG:Debug,RelWithDebInfo>:ProgramDatabase>, (see: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_DEBUG_INFORMATION_FORMAT.html) it might break for Release/MinSizeRel builds as no debug info is generated by default.
We could set MSVC_DEBUG_INFORMATION_FORMAT to ProgramDatabase unconditionally, users can still override it in their own targets, but if they have explicitly set CMAKE_MSVC_DEBUG_INFORMATION_FORMAT to a compatible value we should not override it.
There was a problem hiding this comment.
I just want to make sure we don't have a regression in the default experience, i.e., the address sanitizer should work by default. So as long as that's the case, this change should be OK.
ddassie-texa
force-pushed
the
feature/msvc-debug-format-fix
branch
from
9d44192 to
3262a39
Compare
With the current implementation if CMAKE_MSVC_DEBUG_INFORMATION_FORMAT is set, it won't be respected as the /Zi flag is always set in enable_sanitizers. If POLICY CMP0141 is available, don't set the /Zi flag, instead use MSVC_DEBUG_INFORMATION_FORMAT, if the user didn't set CMAKE_MSVC_DEBUG_INFORMATION_FORMAT or set it to EditAndContinue, than only in that case set it to ProgramDatabase.
ddassie-texa
force-pushed
the
feature/msvc-debug-format-fix
branch
from
3262a39 to
398f901
Compare
With the current implementation if CMAKE_MSVC_DEBUG_INFORMATION_FORMAT is set, it won't be respected as the /Zi flag set on enable_sanitizers will always override it, just skip setting it if POLICY CMP0141 is available, if the user has set CMAKE_MSVC_DEBUG_INFORMATION_FORMAT to EditAndContinue, than only in that case override it.
Fixes #262