add prefetch time in logic #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peze
force-pushed
the
prefetch-upgrade
branch
from
c328cb6 to
55d165f
Compare
yndu13
reviewed
Dec 31, 2024
src/providers/ecs_ram_role.ts
Outdated
| import CredentialsProvider from '../credentials_provider' | ||
| import { Request, doRequest } from './http' | ||
| import Session from './session' | ||
| import { parseUTC } from './time' | ||
| import { Session, SessionCredentialProvider, SCALE_TIME } from './session' |
src/providers/ecs_ram_role.ts
Outdated
| this.roleName = builder.roleName; | ||
| this.disableIMDSv1 = builder.disableIMDSv1; | ||
| this.readTimeout = builder.readTimeout; | ||
| this.connectTimeout = builder.connectTimeout; | ||
| this.checker = this.checkCredentialsUpdateAynchronously(); |
There was a problem hiding this comment.
checkCredentialsUpdateAsynchronously
src/providers/ecs_ram_role.ts
Outdated
| return setTimeout(async () => { | ||
| await this.getCredentials(); | ||
| this.checker = this.checkCredentialsUpdateAynchronously(); | ||
| console.log(this.checker); |
src/providers/ecs_ram_role.ts
Outdated
| checkCredentialsUpdateAynchronously(): NodeJS.Timeout { | ||
| return setTimeout(async () => { | ||
| await this.getCredentials(); | ||
| this.checker = this.checkCredentialsUpdateAynchronously(); |
| getProviderName(): string { | ||
| return 'ram_role_arn'; | ||
| return `ram_role_arn/${this.credentialsProvider.getProviderName()}`; |
There was a problem hiding this comment.
这种方式没有记录上上个Provider链路，仅记录了一层
src/providers/session.ts
Outdated
| this.scaleTimestamp = now; | ||
| } | ||
| // 已过期，看缓存，缓存若大于15分钟，返回缓存，若小于15分钟，则根据策略判断是立刻重试还是稍后重试 | ||
| if (now < this.scaleTimestamp) { |
There was a problem hiding this comment.
这种方式没有区分缓存还是这次请求拿到的，this.scaleTimestamp已修改
peze
force-pushed
the
prefetch-upgrade
branch
2 times, most recently
from
94ba310 to
6f08be7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 98.00% 97.34% -0.66%
==========================================
Files 36 36
Lines 1201 1245 +44
Branches 206 214 +8
==========================================
+ Hits 1177 1212 +35
- Misses 12 18 +6
- Partials 12 15 +3 ☔ View full report in Codecov by Sentry. |
peze
force-pushed
the
prefetch-upgrade
branch
8 times, most recently
from
87ffe60 to
fc01f90
Compare
yndu13
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.