Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #13023]Add Unit Test for ConfigQueryHandlerChainn and optimize the logic #13024

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

Sunrisea
Copy link
Contributor

@Sunrisea Sunrisea commented Jan 8, 2025

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #13023, Add Unit Test for ConfigQueryHandlerChain and handlers, fix the logic of SpecialTagNotFoundHandler, add ConfigContentTypeHandler

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [*] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [*] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [*] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [*] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [*] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link

github-actions bot commented Jan 8, 2025

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (3796395) to head (61c9a3c).

Files with missing lines Patch % Lines
...s/config/server/controller/ConfigServletInner.java 75.00% 3 Missing and 2 partials ⚠️
...ervice/query/handler/ConfigContentTypeHandler.java 91.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13024      +/-   ##
=============================================
+ Coverage      72.31%   72.36%   +0.04%     
- Complexity     10005    10024      +19     
=============================================
  Files           1309     1310       +1     
  Lines          41993    42004      +11     
  Branches        4407     4413       +6     
=============================================
+ Hits           30369    30396      +27     
+ Misses          9497     9486      -11     
+ Partials        2127     2122       -5     
Files with missing lines Coverage Δ
...onfig/server/remote/ConfigQueryRequestHandler.java 85.00% <100.00%> (+0.25%) ⬆️
...e/query/DefaultConfigQueryHandlerChainBuilder.java 100.00% <100.00%> (ø)
...vice/query/handler/AbstractConfigQueryHandler.java 100.00% <100.00%> (+25.00%) ⬆️
...ig/server/service/query/handler/FormalHandler.java 100.00% <100.00%> (+5.26%) ⬆️
...er/service/query/handler/GrayRuleMatchHandler.java 100.00% <100.00%> (+7.40%) ⬆️
...rvice/query/handler/SpecialTagNotFoundHandler.java 100.00% <ø> (+4.76%) ⬆️
.../service/query/model/ConfigQueryChainResponse.java 61.40% <100.00%> (+7.69%) ⬆️
...ervice/query/handler/ConfigContentTypeHandler.java 91.66% <91.66%> (ø)
...s/config/server/controller/ConfigServletInner.java 72.51% <75.00%> (-2.09%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3796395...61c9a3c. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Jan 8, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Jan 8, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@shiyiyue1102 shiyiyue1102 merged commit 8a136c2 into alibaba:develop Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unit Test for ConfigQueryHandlerChain and optimize logic
4 participants