Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
Signed-off-by: liam.baker <[email protected]>

address comments and remove dependency on go-git

Signed-off-by: liam.baker <[email protected]>

Fix for regex for downloading Node.js

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Bump golang.org/x/crypto from 0.14.0 to 0.15.0

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0.
- [Commits](golang/crypto@v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump golang.org/x/mod from 0.13.0 to 0.14.0

Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.13.0 to 0.14.0.
- [Commits](golang/mod@v0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: golang.org/x/mod
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump github.com/spf13/cobra from 1.7.0 to 1.8.0

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

feat: add kwok to arkade get tools

Signed-off-by: Czékus Máté <[email protected]>

feat: add kwokctl to arkade get tools

Signed-off-by: Czékus Máté <[email protected]>

Update system go installation for new format

The endpoint on go.dev now returns additional text after the
version, \ntime.

This change trims off the second half of the output.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Bump golang.org/x/crypto from 0.15.0 to 0.16.0

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0.
- [Commits](golang/crypto@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Bump github.com/google/go-containerregistry from 0.16.1 to 0.17.0

Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](google/go-containerregistry@v0.16.1...v0.17.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Add rgee/snowmachine for the festive period

Signed-off-by: Richard Gee <[email protected]>

Bump actions/setup-go from 4 to 5

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Update README.md

Signed-off-by: Alex Ellis <[email protected]>

Export LoadFrom

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Bump go.mod and vendor

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Fix issue with version flag for Helm charts

The version was being specified in an invalid way in args
for the helm command via a string with a space. This has been
changed to use a slice.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Bump golang.org/x/crypto from 0.16.0 to 0.17.0

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](golang/crypto@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Move to Go 1.21 for builds and minimum version

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Limit builds for same SHA

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Use Go 1.21 for e2e checker

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

resolve modules.txt

Signed-off-by: liam.baker <[email protected]>

explicit sudo as documented in arkade.tape

Signed-off-by: liam.baker <[email protected]>

remove run elevated

Signed-off-by: liam.baker <[email protected]>

mod vendor

Signed-off-by: liam.baker <[email protected]>
  • Loading branch information
liam.baker committed Jan 4, 2024
1 parent c0f395b commit c1862d9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 21 deletions.
26 changes: 5 additions & 21 deletions cmd/system/aws_cli.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package system

import (
"bufio"
"bytes"
"context"
"encoding/json"
Expand All @@ -25,8 +24,6 @@ import (
"github.com/spf13/cobra"
)

var runElevated bool

type ReferenceObject struct {
Type string `json:"tag,omitempty"`
}
Expand Down Expand Up @@ -54,18 +51,6 @@ func MakeInstallAWSCLI() *cobra.Command {
command.Flags().Bool("run-installer", true, "Whether or not arkade should run the downloaded installer")

command.PreRunE = func(cmd *cobra.Command, args []string) error {
fmt.Printf("Allow arkade to perform an elevated install (i.e. sudo)?\n\n")
fmt.Println("Enter a value: ")
reader := bufio.NewReader(os.Stdin)
input, err := reader.ReadString('\n')
if err != nil {
return err
}

if strings.EqualFold(input, "yes") {
runElevated = true
}

return nil
}

Expand Down Expand Up @@ -179,7 +164,7 @@ func MakeInstallAWSCLI() *cobra.Command {
workDir = unpackPath
}

if runInstaller && runElevated {
if runInstaller {
if err := runBundledInstaller(osVer, workDir, filename, installPath); err != nil {
return err
}
Expand Down Expand Up @@ -261,13 +246,12 @@ func runBundledInstaller(osVer string, workDir string, filename string, installP

switch osVer {
case "Darwin":
cmd = "sudo"
cmd = "installer"
pkgDir := fmt.Sprintf(" -pkg %s/%s", workDir, filename)
args = append(args, "installer", pkgDir, "-target /")
args = append(args, pkgDir, "-target /")
case "Linux":
cmd = "sudo"
installerDir := fmt.Sprintf(".%s/install", workDir)
args = append(args, installerDir, fmt.Sprintf("--bin-dir %s", installPath))
cmd = fmt.Sprintf(".%s/install", workDir)
args = append(args, fmt.Sprintf("--bin-dir %s", installPath))
default:
if strings.HasPrefix(osVer, "Ming") {
cmd = "msiexec"
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ require (
github.com/sethvargo/go-password v0.2.0
github.com/spf13/cobra v1.8.0
golang.org/x/crypto v0.17.0
golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc
golang.org/x/mod v0.14.0
gopkg.in/yaml.v3 v3.0.1
)
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ github.com/vbatts/tar-split v0.11.5 h1:3bHCTIheBm1qFTcgh9oPu+nNBtX+XJIupG/vacinC
github.com/vbatts/tar-split v0.11.5/go.mod h1:yZbwRsSeGjusneWgA781EKej9HF8vme8okylkAeNKLk=
golang.org/x/crypto v0.17.0 h1:r8bRNjWL3GshPW3gkd+RpvzWrZAwPS49OmTGZ/uhM4k=
golang.org/x/crypto v0.17.0/go.mod h1:gCAAfMLgwOJRpTjQ2zCCt2OcSfYMTeZVSRtQlPC7Nq4=
golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc h1:ao2WRsKSzW6KuUY9IWPwWahcHCgR0s52IfwutMfEbdM=
golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc/go.mod h1:iRJReGqOEeBhDZGkGbynYwcHlctCvnjTYIamk7uXpHI=
golang.org/x/mod v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0=
golang.org/x/mod v0.14.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
golang.org/x/sync v0.5.0 h1:60k92dhOjHxJkrqnwsfl8KuaHbn/5dl0lUPUklKo3qE=
Expand Down
4 changes: 4 additions & 0 deletions vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ github.com/vbatts/tar-split/archive/tar
## explicit; go 1.18
golang.org/x/crypto/bcrypt
golang.org/x/crypto/blowfish
# golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc
## explicit; go 1.20
golang.org/x/exp/constraints
golang.org/x/exp/slices
# golang.org/x/mod v0.14.0
## explicit; go 1.18
golang.org/x/mod/semver
Expand Down

0 comments on commit c1862d9

Please sign in to comment.