Move Rails engine hooks into after_initialize #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move Rails engine hooks into
after_initialize
Why
After adding
action_markdown
to a Rails 7.1 application that was already using sorcery the application would raise an error at startup.To be fair action_markdown works fine with stock Rails 7.1, and socery is known Sorcery/sorcery#308 (comment) to have Rails 7 compatibility problems. But hopefully this will at save someone a couple hours if they run into the same problem.