Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcut buttons and address list to Token Details Modal #1237

Open
wants to merge 15 commits into
base: dw-redesign
Choose a base branch
from
Open

Add shortcut buttons and address list to Token Details Modal #1237

wants to merge 15 commits into from

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Feb 7, 2025

No description provided.

@nop33 nop33 requested a review from mvaivre February 7, 2025 14:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cc04372

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nop33 nop33 changed the title Add shortcut buttons to Token Details Modal Add shortcut buttons and address list to Token Details Modal Feb 7, 2025
@nop33 nop33 added the 🖥 DW Desktop wallet label Feb 10, 2025
@nop33 nop33 force-pushed the dw-redesign-ilias branch from dff5105 to 97229d7 Compare February 10, 2025 16:20
@nop33 nop33 mentioned this pull request Feb 11, 2025
Open
@mvaivre
Copy link
Member

mvaivre commented Feb 11, 2025

Nice one!
In terms of UX, what would make the most sense IMO is to provide the list of latest transactions involving the tokens. The detailed list of addresses containing the token comes second IMO (we know that the large majority of our users only have 1 address).
Because this PR is still rather smol, would you mind implementing this? 🚀

What I'd love to see:

  • Like on MW, a box with the token description
  • Under the box, a tabbar allowing to switch between "Latest transactions" and "Addresses".

WDYT? Once we have this + the last UI fixes I need to do before end of week, we'll be ready to ship 3.0!

@nop33
Copy link
Member Author

nop33 commented Feb 11, 2025

Sure, I'll work on these features tomorrow!

nop33
nop33 commented Feb 12, 2025
View reviewed changes
apps/desktop-wallet/package.json
@@ -131,6 +131,7 @@
"react-confetti": "^6.0.1",
"react-detect-click-outside": "^1.1.2",
"react-dom": "^18.2.0",
"react-freeze": "^1.0.4",
Copy link
Member Author

@nop33 nop33 Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced to improve performance by "freezing" the hidden tab content after I improved the tab navigation everywhere by keeping the previous tab mounted.

@nop33
Copy link
Member Author

nop33 commented Feb 12, 2025

@mvaivre re-requesting review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaivre mvaivre Awaiting requested review from mvaivre

Assignees
No one assigned
Labels
🖥 DW Desktop wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nop33 @mvaivre