Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable Jabba script (and cache) #56

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

ignasi35
Copy link
Contributor

Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK :)

We're using a lot of variations of this snippet - that's not necessarily a problem (no need to update the world when we come up with / try out an improvement in one place), but it'd be nice if we had a central place to keep track of what the 'current best practice' (tm) is :D

@raboof
Copy link
Contributor

raboof commented Sep 21, 2020

Fails though:

$ jabba install $(jabba ls-remote "adopt@~1.$TRAVIS_JDK.0-0" --latest=patch) && jabba use "$_" && java -Xmx32m -version
adopt@[email protected] is not a valid version

@ignasi35
Copy link
Contributor Author

We're using a lot of variations of this snippet - that's not necessarily a problem (no need to update the world when we come up with / try out an improvement in one place), but it'd be nice if we had a central place to keep track of what the 'current best practice' (tm) is :D

Completely agree, I think it's time we settled and started adopting https://github.com/scala/scala-dev/blob/scala-dev/travis/default.yml as a parent template and forget about the problem

@ignasi35
Copy link
Contributor Author

raised akka/akka-meta#141

@raboof raboof merged commit 8c332f4 into akka:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants