Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 404 compat-table url #2955

Merged
merged 5 commits into from
Mar 25, 2024
Merged

update 404 compat-table url #2955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09adc22
[eslint config] [patch] `jsx-a11y/no-noninteractive-tabindex`: allow …
ljharb Jan 30, 2024
b239920
[eslint config] [patch] `jsx-a11y/no-redundant-roles`: allow `nav` to…
ljharb Jan 30, 2024
5f019b1
[eslint config] [*] [dev deps] update `tape`
ljharb Mar 25, 2024
932951a
[eslint config] [deps] update `eslint-plugin-react`
ljharb Mar 25, 2024
f20eca9
[guide] fix compat table URL
muhammedriaz Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3406,7 +3406,7 @@ Other Style Guides
this.firstName = 'Panda';

// good, in environments where WeakMaps are available
// see https://kangax.github.io/compat-table/es6/#test-WeakMap
// see https://compat-table.github.io/compat-table/es6/#test-WeakMap
const firstNames = new WeakMap();
firstNames.set(this, 'Panda');
```
Expand Down Expand Up @@ -3860,7 +3860,7 @@ Other Style Guides

- [Latest ECMA spec](https://tc39.github.io/ecma262/)
- [ExploringJS](https://exploringjs.com/)
- [ES6 Compatibility Table](https://kangax.github.io/compat-table/es6/)
- [ES6 Compatibility Table](https://compat-table.github.io/compat-table/es6/)
- [Comprehensive Overview of ES6 Features](http://es6-features.org/)
- [JavaScript Roadmap](https://roadmap.sh/javascript)

Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-airbnb-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"eslint-plugin-import": "^2.29.1",
"in-publish": "^2.0.1",
"safe-publish-latest": "^2.0.0",
"tape": "^5.7.4"
"tape": "^5.7.5"
},
"peerDependencies": {
"eslint": "^7.32.0 || ^8.2.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/eslint-config-airbnb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,18 @@
"eslint-find-rules": "^4.1.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react": "^7.34.1",
"eslint-plugin-react-hooks": "^4.6.0",
"in-publish": "^2.0.1",
"react": ">= 0.13.0",
"safe-publish-latest": "^2.0.0",
"tape": "^5.7.4"
"tape": "^5.7.5"
},
"peerDependencies": {
"eslint": "^7.32.0 || ^8.2.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react": "^7.34.1",
"eslint-plugin-react-hooks": "^4.6.0"
},
"engines": {
Expand Down
5 changes: 4 additions & 1 deletion packages/eslint-config-airbnb/rules/react-a11y.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ module.exports = {
'jsx-a11y/no-noninteractive-tabindex': ['error', {
tags: [],
roles: ['tabpanel'],
allowExpressionValues: true,
}],

// require onBlur instead of onChange
Expand All @@ -200,7 +201,9 @@ module.exports = {

// ensure HTML elements do not specify redundant ARIA roles
// https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-redundant-roles.md
'jsx-a11y/no-redundant-roles': 'error',
'jsx-a11y/no-redundant-roles': ['error', {
nav: ['navigation'],
}],

// Enforce that DOM elements without semantic behavior not have interaction handlers
// https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md
Expand Down
7 changes: 7 additions & 0 deletions packages/eslint-config-airbnb/rules/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ module.exports = {
],
}],

// This rule enforces onChange or readonly attribute for checked property of input elements.
// https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/checked-requires-onchange-or-readonly.md
'react/checked-requires-onchange-or-readonly': ['off', {
ignoreMissingProperties: false,
ignoreExclusiveCheckedAttribute: false
}],

// Prevent missing displayName in a React component definition
// https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md
'react/display-name': ['off', { ignoreTranspilerName: false }],
Expand Down
Loading