Implement support for the free-threaded build of CPython 3.13 #84
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Hey folks, thanks for all the review and sorry for the extended delay here, I was out on PTO. I've addressed most of the comments around adding some TODOs and replied to the rest. |
CodSpeed Performance ReportMerging #84 will degrade performances by 8.05%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 89.02% 89.03% +0.01%
==========================================
Files 18 18
Lines 738 739 +1
Branches 75 75
==========================================
+ Hits 657 658 +1
Misses 63 63
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Gentle ping on this. Is there anything I can do to move it forward? |
packaging/pep517_backend/_backend.py
Outdated
| @@ -372,7 +372,8 @@ def get_requires_for_build_wheel( | |||
| ) | |||
|
|
|||
| c_ext_build_deps = [] if is_pure_python_build else [ | |||
| 'Cython ~= 3.0.0; python_version >= "3.12"', | |||
| 'Cython == 3.1.0a1; python_version >= "3.13"', | |||
There was a problem hiding this comment.
Looks like the performance regression is coming from 3.1.0a1.
We should only use 3.1.0a1 if its the free-threading 3.13 so this doesn't affect the current 3.13 production builds
There was a problem hiding this comment.
@lysnikolaou sorry for the delay
I think this is good to go once https://github.com/aio-libs/propcache/pull/84/files#r1925771536 is addressed
What do these changes do?
Are there changes in behavior for the user?
No.
Related issue number
Checklist