Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github arm runners for docker arm build tests #6717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (aa0aa26) to head (aca6050).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6717      +/-   ##
==========================================
+ Coverage   78.05%   78.06%   +0.01%     
==========================================
  Files         563      563              
  Lines       41790    41790              
==========================================
+ Hits        32616    32618       +2     
+ Misses       9174     9172       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good. Nice.

@danielhollas danielhollas marked this pull request as ready for review January 17, 2025 18:21
@danielhollas
Copy link
Collaborator Author

I'd suggest to hold of merging this for a week or two to give GitHub chance to iron out any initial issues.

For example, I am seeing weird permissions errors in the job logs:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants