Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required make it possible to run with pytest-xdist #6631

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 22, 2024

pytest-xdist although not run through CI, but can run from local if the changes here are adapted. The changes needed since xdist has a know limitation that the order and amount of test must be consistent.

pytest-xdist although not run through CI, but can run from local if the
changes here are adapted. The changes needed since xdist has a know
limitation that the order and amount of test must be consistent.
@unkcpz unkcpz requested a review from danielhollas November 22, 2024 11:23
Copy link
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, LGTM!

This is a clear improvement regardless of original motivation.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (ef60b66) to head (7c17de9).
Report is 135 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6631      +/-   ##
==========================================
+ Coverage   77.51%   77.90%   +0.40%     
==========================================
  Files         560      567       +7     
  Lines       41444    42147     +703     
==========================================
+ Hits        32120    32831     +711     
+ Misses       9324     9316       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@unkcpz unkcpz merged commit 1c5f109 into aiidateam:main Nov 22, 2024
9 of 10 checks passed
@unkcpz unkcpz deleted the xdist-local-fix branch November 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants