CI: Drop workaround to pass pymatgen related failed tests (#6694)

aiidateam · Jan 10, 2025 · d17c293 · d17c293
1 parent 5e8bbe1
commit d17c293
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 110 deletions.
diff --git a/.github/workflows/ci-code.yml b/.github/workflows/ci-code.yml
@@ -76,12 +76,9 @@ jobs:
         AIIDA_WARN_v3: 1
       # NOTE1: Python 3.12 has a performance regression when running with code coverage
       # so run code coverage only for python 3.9.
-      # NOTE2: Unset CI envvar to workaround a pymatgen issue for Python 3.9
-      # https://github.com/materialsproject/pymatgen/issues/4243
       # TODO: Remove a workaround for VIRTUAL_ENV once the setup-uv action is updated
       # https://github.com/astral-sh/setup-uv/issues/219
       run: |
-        ${{ matrix.python-version == '3.9' && 'unset CI' || '' }}
         ${{ matrix.python-version == '3.9' && 'VIRTUAL_ENV=$PWD/.venv' || '' }}
         pytest -n auto --db-backend ${{ matrix.database-backend }} -m 'not nightly' tests/ ${{ matrix.python-version == '3.9' && '--cov aiida' || '' }}
 

diff --git a/.github/workflows/test-install.yml b/.github/workflows/test-install.yml
@@ -211,11 +211,8 @@ jobs:
       env:
         AIIDA_TEST_PROFILE: test_aiida
         AIIDA_WARN_v3: 1
-      # Unset CI envvar to workaround a pymatgen issue for Python 3.9
-      # https://github.com/materialsproject/pymatgen/issues/4243
       # TODO: Remove a workaround for VIRTUAL_ENV once the setup-uv action is updated
       # https://github.com/astral-sh/setup-uv/issues/219
       run: |
-        ${{ matrix.python-version == '3.9' && 'unset CI' || '' }}
         ${{ matrix.python-version == '3.9' && 'VIRTUAL_ENV=$PWD/.venv' || '' }}
         pytest -n auto --db-backend psql -m 'not nightly' tests/