-
Notifications
You must be signed in to change notification settings - Fork 207
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use uv-pre-commit to validate lockfile (#6699)
The previous uv hook that checked whether uv lockfile is up-to-date required the developer to have uv installed. Using the official uv-pre-commit hook, this is no longer the case. The hook also updates the lock automatically, instead of just checking its status. Bump minimum version of uv to `0.5.21` fix issue astral-sh/uv#10689 uv does run the build backend for projects with dynamic versioning. Bump astral-sh/setup-uv action to v5.2.1. Change in `.github/workflows/ci-code.yml` (`file` -> `files`) is related to fixing a warning in the CI.
- Loading branch information
1 parent
eba6954
commit 208d6a9
Showing
6 changed files
with
19 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,9 +31,9 @@ runs: | |
python-version: ${{ inputs.python-version }} | ||
|
||
- name: Set up uv | ||
uses: astral-sh/[email protected].0 | ||
uses: astral-sh/[email protected].1 | ||
with: | ||
version: 0.5.x | ||
version: 0.5.22 | ||
python-version: ${{ inputs.python-version }} | ||
|
||
- name: Install dependencies from uv lock | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,16 +38,13 @@ jobs: | |
python-version: '3.11' | ||
|
||
- name: Set up uv | ||
uses: astral-sh/[email protected].0 | ||
uses: astral-sh/[email protected].1 | ||
with: | ||
version: 0.5.x | ||
version: latest | ||
|
||
- name: Install utils/ dependencies | ||
run: uv pip install --system -r utils/requirements.txt | ||
|
||
- name: Validate uv lockfile | ||
run: uv lock --check | ||
|
||
- name: Validate conda environment file | ||
run: python ./utils/dependency_management.py validate-environment-yml | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
208d6a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'pytest-benchmarks:ubuntu-22.04,psql_dos'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.tests/benchmark/test_json_contains.py::test_deep_json[4-8]
2.1607302506634647
iter/sec (stddev: 0.0065499
)200.2768503928645
iter/sec (stddev: 0.000074018
)92.69
This comment was automatically generated by workflow using github-action-benchmark.
CC: @giovannipizzi @agoscinski @GeigerJ2 @khsrali @unkcpz