Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 violation #201

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix flake8 violation #201

merged 1 commit into from
Jan 24, 2024

Conversation

danielhollas
Copy link
Contributor

flake8 currently fails on main (I have no idea why the CI is green on the latest commit though, very strange). This is the error:

aiidalab_launch/profile.py:94:17: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
                self.extra_mounts.remove(extra_mount)

@danielhollas danielhollas changed the title Fix precommit Fix flake8 violation Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ce5a06) 86.54% compared to head (b991c86) 86.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   86.54%   86.32%   -0.22%     
==========================================
  Files           9        9              
  Lines         914      914              
==========================================
- Hits          791      789       -2     
- Misses        123      125       +2     
Flag Coverage Δ
py-3.10 86.21% <100.00%> (ø)
py-3.11 86.21% <100.00%> (ø)
py-3.12 86.21% <100.00%> (-0.22%) ⬇️
py-3.8 86.16% <100.00%> (ø)
py-3.9 86.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@unkcpz unkcpz merged commit f3b3ea5 into main Jan 24, 2024
18 checks passed
@unkcpz unkcpz deleted the fix-precommit branch January 24, 2024 08:50
@unkcpz
Copy link
Member

unkcpz commented Jan 24, 2024

(I have no idea why the CI is green on the latest commit though, very strange)

No idea.. Maybe the dependencies in your environment are slightly different? But anyway, the change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants