-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Podman #197
Merged
Merged
Support Podman #197
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c75a7f8
Support Podman
danielhollas 8b41ba4
Try specifying a concrete port in conftest.p
danielhollas a4bc1f8
Add debug print
danielhollas aed5916
Appease pre-commit
danielhollas dba82bb
Merge branch 'main' into podman
danielhollas 3ea0a88
Comment out problematic code
danielhollas ab3f94b
Rollback DEFAULT_IMAGE
danielhollas 3ea81f1
Copy the set during iteration
danielhollas aa626e0
Fold pre-commit into dev extras
danielhollas 08a4675
Add docker.io prefix again
danielhollas 7c2a7d0
Merge branch 'main' into podman
danielhollas 5d58daf
Workround for Docker stripping docker.io
danielhollas fb3f9fe
Decrease debug output
danielhollas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,7 +78,7 @@ def _pull_docker_image(docker_client): | |
# Avoid interfering with used ports on the host system. | ||
@pytest.fixture(scope="session", autouse=True) | ||
def _default_port(monkeypatch_session): | ||
monkeypatch_session.setattr(aiidalab_launch.profile, "DEFAULT_PORT", None) | ||
monkeypatch_session.setattr(aiidalab_launch.profile, "DEFAULT_PORT", 7777) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Podman seems to autoassign random port, so the tests were failing for me locally. |
||
yield None | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!