Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datasets) Update type hinting generics based on typing module #4750

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

adam-narozniak
Copy link
Contributor

Issue

Flower datasets in 2 files still uses the Type Hinting Generics from typing module == from typing import List, Tuple

Proposal

Update (as suggested by the formatter) the Type Hinting Generics from typing module to directly using standard collections (dict, list, ...)

Explanation

As PEP 585 suggests from python 3.9 the latter is possible seamlessly + the automatic change happens when using the formatting script.

@jafermarq jafermarq enabled auto-merge (squash) December 20, 2024 10:57
@jafermarq jafermarq merged commit 3594d44 into main Dec 20, 2024
61 checks passed
@jafermarq jafermarq deleted the fds-fix-types branch December 20, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants