refactor(datasets) Update type hinting generics based on typing module #4750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Flower datasets in 2 files still uses the Type Hinting Generics from typing module ==
from typing import List, Tuple
Proposal
Update (as suggested by the formatter) the Type Hinting Generics from typing module to directly using standard collections (
dict
,list
, ...)Explanation
As PEP 585 suggests from python 3.9 the latter is possible seamlessly + the automatic change happens when using the formatting script.