Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ports/espressif/supervisor/usb.c: workaround ESP32-S3 USB PHY setup (cont) #9986

Merged
merged 2 commits into from
Jan 21, 2025
Merged

ports/espressif/supervisor/usb.c: workaround ESP32-S3 USB PHY setup (cont) #9986

merged 2 commits into from
Jan 21, 2025

Conversation

hathach
Copy link
Member

@hathach hathach commented Jan 21, 2025

similar to #9973 but a bit cleaner

@hathach hathach requested a review from dhalbert January 21, 2025 06:28
dhalbert
dhalbert requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fixing a typo

ports/espressif/supervisor/usb.c Outdated Show resolved Hide resolved
dhalbert
dhalbert approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Metro ESP32-S3, works fine on direct connection and through hub. Also tested Metro ESP32-S2, which should not have been affected, and wasn't.

@dhalbert dhalbert merged commit 1dc332e into adafruit:main Jan 21, 2025
42 of 229 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hathach @dhalbert