Skip to content

Commit

Permalink
ESP8266: Stop supporting 400khz neopixels through old esp module API.
Browse files Browse the repository at this point in the history
It still accepts the parameter for backwards compatibility and to
provide a good error when it can't work.

Using the `neopixel_write` module instead is recommended because its
available on all CircuitPython supported ports.
  • Loading branch information
tannewt committed Feb 22, 2017
1 parent 44e5d36 commit fc718d9
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion esp8266/modesp.c
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,11 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_check_fw_obj, esp_check_fw);
STATIC mp_obj_t esp_neopixel_write_(mp_obj_t pin, mp_obj_t buf, mp_obj_t is800k) {
mp_buffer_info_t bufinfo;
mp_get_buffer_raise(buf, &bufinfo, MP_BUFFER_READ);
if (!mp_obj_is_true(is800k)) {
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Only 800khz neopixels are supported."));
}
esp_neopixel_write(mp_obj_get_pin_obj(pin)->phys_port,
(uint8_t*)bufinfo.buf, bufinfo.len, mp_obj_is_true(is800k));
(uint8_t*)bufinfo.buf, bufinfo.len);
return mp_const_none;
}
STATIC MP_DEFINE_CONST_FUN_OBJ_3(esp_neopixel_write_obj, esp_neopixel_write_);
Expand Down

0 comments on commit fc718d9

Please sign in to comment.