Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve set_port validation and get_host behavior #829

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Improve set_port validation and get_host behavior #829

wants to merge 7 commits into from

Conversation

mertcanaltin
Copy link

fix Ensure set_port correctly handles invalid port values

#826

@anonrig anonrig requested a review from lemire January 5, 2025 22:25
anonrig
anonrig reviewed Jan 5, 2025
View reviewed changes
src/url_aggregator.cpp Show resolved Hide resolved
tests/basic_tests.cpp Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Jan 5, 2025
View reviewed changes
tests/basic_tests.cpp Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Jan 5, 2025
View reviewed changes
src/ada_c.cpp Outdated Show resolved Hide resolved
@mertcanaltin @anonrig
Update tests/basic_tests.cpp
51d283c 
Co-authored-by: Yagiz Nizipli <[email protected]>
anonrig
anonrig reviewed Jan 5, 2025
View reviewed changes
tests/basic_tests.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@lemire lemire Awaiting requested review from lemire

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertcanaltin @anonrig