Add WiX bin folder to PATH.

[lzandman]

Description

As mentioned in issue "WiX toolkit is not in the PATH" #9551 the WiX installer does not add its bin folder to the PATH environment variable. However, it does set the WIX environment variable, pointing to the WiX install folder. This code adds WiX bin folder using the path that's defined in the WIX environment variable, so WiX commands can be called directly from the command-line.

Related issue:

#9551

[lzandman]

Should a test for this also be added?

[erik-bershel]

Hey @lzandman!
Thanks for help with this. And yes, please pay attention to the tests. As you rightly noted, it would be nice to add them. I sketched out a quick example of what we would like to see: 4f71e8c

[lzandman]

I sketched out a quick example of what we would like to see.

Why is the WiX version retrieved using a somewhat complicated registry query? Many other apps are tested by calling the app itself. The way I see it WiX's install could be tested by this single test:

Describe "Wix" {
    It "Wix Toolset has been installed and is available in PATH" {
        "candle.exe -?" | Should -ReturnZeroExitCode
    }
}

[erik-bershel]

Hey @lzandman

Why is the WiX version retrieved using a somewhat complicated registry query?

Because on the Chocolatey side there were occasional weird packaging errors that would result in us getting unexpected versions of the WIX toolset.

[erik-bershel]

I'm closing this PR because I do not have enough rights to make changes to save time, and I would like these changes to be included in the image next week.

[lzandman]

I'm closing this PR because I do not have enough rights to make changes to save time, and I would like these changes to be included in the image next week.

I don't understand. This PR fixes a real issue a user is experiencing. Is the plan to not fix this issue? Or is it just that my code isn't OK?