Ignore submissions without metadata #137
Conversation
|
Warning Rate limit exceeded@lalinsky has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
WalkthroughThe changes involve modifying the submission handling logic in two files within the Acoustid project. In Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
acoustid/api/v2/__init__.py (1)
Line range hint
1-994: Format the code using Black.The pipeline indicates that the code formatting does not match Black style guidelines. Please run Black on this file to fix the formatting issues.
🧰 Tools
🪛 GitHub Actions: Build and test
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
acoustid/api/v2/__init__.py(1 hunks)acoustid/data/submission.py(4 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build and test
acoustid/data/submission.py
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
acoustid/api/v2/__init__.py
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test (3.12)
🔇 Additional comments (4)
acoustid/data/submission.py (3)
81-84: LGTM! Clear and accurate metadata validation checks.The boolean variables effectively validate the presence of metadata by checking for non-empty and non-zero UUIDs for MBIDs and PUIDs, and the presence of either meta_id or meta.
🧰 Tools
🪛 GitHub Actions: Build and test
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
Line range hint
195-205: LGTM! Consistent use of the metadata validation flag.The code correctly uses the pre-computed
has_mbidflag to determine whether to insert the MBID.🧰 Tools
🪛 GitHub Actions: Build and test
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
Line range hint
206-216: LGTM! Consistent use of the metadata validation flag.The code correctly uses the pre-computed
has_puidflag to determine whether to insert the PUID.🧰 Tools
🪛 GitHub Actions: Build and test
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
acoustid/api/v2/__init__.py (1)
993-994: LGTM! Consistent metadata validation.The code correctly validates the presence of metadata and skips submissions without any metadata. This change aligns with the PR objective and is consistent with the validation in
submission.py.🧰 Tools
🪛 GitHub Actions: Build and test
[warning] Code formatting does not match Black style guidelines. File needs to be reformatted using Black.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
Bug Fixes
Refactor