Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basic theme blazor menu remain open problem. #21841

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix basic theme blazor menu remain open problem. #21841

merged 2 commits into from
Jan 13, 2025

Conversation

maliming
Copy link
Member

@maliming maliming commented Jan 8, 2025

Resolve #21840

@maliming maliming added this to the 9.0-patch-final milestone Jan 8, 2025
@gizemmutukurt gizemmutukurt requested review from oykuermann and removed request for enisn January 8, 2025 10:38
@oykuermann oykuermann requested review from enisn and removed request for gizemmutukurt January 8, 2025 11:27
oykuermann
oykuermann requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can open Language selection and Administration menus at the same time:
image

@maliming
Copy link
Member Author

I can open Language selection and Administration menus at the same time: <img alt="image"

This is not a problem. You can ignore it. Because it will not block the menu.

@oykuermann
Copy link
Contributor

I think it is a problem. Two menus should not remain open. If Administration menu is opened, after opening Language Selection, Admin should be closed. It's the best for user experience. These rules should also contain User menu.

@maliming
Copy link
Member Author

ok, I will check it again.

@maliming maliming requested review from enisn and oykuermann January 11, 2025 09:34
@maliming
Copy link
Member Author

@oykuermann You can test again. I have updated the code.

oykuermann
oykuermann requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Click the username to open user menu.
  2. Hover on the Language selection menu and see two menus overlapping:
AbpSolution436.-.Google.Chrome.2025-01-13.10-54-14.-.Trim.-.Trim.mp4

@maliming
Copy link
Member Author

@oykuermann

Please share your test project.
[email protected]
Thanks

@oykuermann oykuermann merged commit 6f6c3ea into rel-9.0 Jan 13, 2025
3 checks passed
@oykuermann oykuermann deleted the Basic-Menu branch January 13, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oykuermann oykuermann oykuermann approved these changes

@enisn enisn enisn approved these changes

Assignees
No one assigned
Labels
abp-module-basic-theme ui-blazor
Projects
None yet
Milestone
9.0-patch-final
Development

Successfully merging this pull request may close these issues.
3 participants
@maliming @oykuermann @enisn