-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance comment time formatting with localized time ago display #21329
Enhance comment time formatting with localized time ago display #21329
Conversation
- Implemented dynamic time ago formatting for comment timestamps - Added localization support for both English and Arabic
Better late than never! 😂@berkansasmaz |
Thanks for your contribution. It seems very nice, I'll check when I start working on the next milestone 👍 |
Hello @enisn, I’ve just resolved the merge conflicts, but I’m concerned that more conflicts might arise if the review gets delayed. 😅 |
Hi @enisn @berkansasmaz, just following up on this PR. I believe it's simple and a great improvement for the UX. |
I think we use luxon or something similar to represent relative dates. Probably there is no dependency on CMSKit to it. I'll check once more and if it's possible, using it might be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I'll merge it since CMS Kit doesn't have a direct dependency on luxon. We may update it later but it seems ok for now 👍
This PR addresses issue #11225, enhancing the comment timestamp display by introducing a concise time ago format with the ability to toggle to a more readable timestamp upon user interaction.
Changes Include: