support "extends" from embassy data. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnite
requested changes
Jan 17, 2025
mattnite
requested changes
Jan 17, 2025
taylorh140
commented
Jan 17, 2025
taylorh140
commented
Jan 17, 2025
taylorh140
commented
Jan 17, 2025
mattnite
approved these changes
Jan 17, 2025
Attempted to support "extends" syntax in register json files
its easy to miss a few. Co-authored-by: Matt Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to support "extends" syntax in register json files.
The added functions aggregate the extends and injects them into the Json.Value parsed from the register files.
it works by traveling down the "extends" and bringing a dictionary with it adding new "items" or "fields" as it travels down the ancestor's lineage.
I expect I'll have to clean up some stuff. but I was just glad I could get it to work.
It does use a arena allocator for the json injections. so they can be cleaned up at the same time.