✨ add notification section #567
Conversation
MailyLehoux
force-pushed
the
feat/notifications
branch
from
8ef7c28 to
4f34d7c
Compare
MailyLehoux
force-pushed
the
feat/notifications
branch
from
4f34d7c to
2d044bc
Compare
MailyLehoux
changed the title
MailyLehoux
changed the title
MailyLehoux
changed the title
There was a problem hiding this comment.
-
Hasura migrations should be refactored to avoid lots of migration (especially migrations that are not used like multiple rename migration).
-
Instead of having a relationship between a notification and a skill, I think it would be better to have the text of the notification directly in the database. Because in the future, there might be other notifications that don't need the skills
-
Same thing of having a creator column in the Skill table, in this way we inform the creator only but not other consultants that add this skill during the skill validation period.
What do you think ?
Otherwise, this new feature is really nice and might be used for multiple informations 🦾
|
|
||
| ### MG_NOTIFICATIONS | ||
|
|
||
| > If admin approve a skill added by a user, the user receive a notification |
There was a problem hiding this comment.
| > If admin approve a skill added by a user, the user receive a notification | |
| > If admin approves a skill added by a user, the user receives a notification |
typo
| notification: { | ||
| notificationText: | ||
| "L'administrateur adminMail a approuvé votre compétence skillName comme nouvelle compétence Skillz", | ||
| new: "Nouveau", | ||
| notificationTypeAccepted: "Une de tes compétence a été acceptée", | ||
| }, |
There was a problem hiding this comment.
It's weird to have the you "singular" and "plurial" on the same page.
| color?: string | null | undefined; | ||
| x?: string | null | undefined; | ||
| y?: string | null | undefined; | ||
| index?: number | null | undefined; |
There was a problem hiding this comment.
I'm the opinion of using Partial<CategoryItem> where it is needed instead of change the database object representation in the wrong way (for example, color is never null in the database)
resolve #377