-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turkish language for wurst #1114
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the Turkish translation file located at Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/main/resources/assets/wurst/translations/tr_tr.json (4)
2-6
: Consistency in Feature Descriptions (AimAssist)
The translations for the AimAssist-related keys are clear and consistent. One suggestion is to verify that all similar entries (e.g. for AimAssist settings) follow a uniform punctuation style—either consistently ending with a period or not—to enhance readability and maintain consistency across translation entries.
7-16
: Clarity and Readability in Airplace and AnchorAura Entries
The entries for Airplace and AnchorAura provide detailed instructions and feature explanations. In particular, the AnchorAura description (line 10) is lengthy. Consider breaking it into shorter sentences or using additional punctuation (e.g. semicolons) to make it easier for users to quickly grasp the functionality.
17-24
: Formatting and Consistency in Anti-AFK Translations
The Anti-AFK feature entries use newline characters effectively to separate different aspects of the description. Ensure that the tone and style remain consistent with other translation sections, particularly in how warnings or extra notes are presented.
25-300
: Comprehensive Translation Entries Review
The remaining translation entries cover a wide array of hacks, settings, and UI elements with appropriate warnings and formatting codes (e.g., “§c§lUYARI:§r”). Overall, the texts are detailed and provide clear instructional context. For long entries with multiple instructions or notes, you might consider a periodic review to ensure clarity and consistency. Additionally, grouping similar keys (such as all “description.wurst.hack.” entries or “description.wurst.setting.” entries) either via file organization or internal documentation can enhance maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/assets/wurst/translations/tr_tr.json
(1 hunks)
🔇 Additional comments (1)
src/main/resources/assets/wurst/translations/tr_tr.json (1)
1-301
: Overall JSON Structure and Encoding
The file is a well-formed JSON object containing a comprehensive set of Turkish translation entries for various Wurst features. Please ensure the file is saved with UTF-8 encoding so that all special Turkish characters display correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
src/main/resources/assets/wurst/translations/tr_tr.json (5)
1-301
: Overall JSON Structure & Translation Completeness
The JSON file is well-formed and comprehensive, covering an extensive range of keys for various Wurst mod features. The key names follow a consistent naming convention and the values are detailed and contextually appropriate. Please verify that all domain-specific terms (e.g., technical jargon and warning formatting such as “§c§lUYARI:§r”) match the established localization style in other language files.
7-9
: Airplace Feature Translation
The descriptions for the Airplace functionality are concise and understandable. Consider reviewing the phrasing in"description.wurst.hack.airplace"
and its associated settings to ensure maximum clarity—for example, confirming that “blokları havada yerleştirmenizi sağlar” conveys the intended meaning in gameplay.
10-16
: AnchorAura Translation Review
The AnchorAura translations are detailed and cover multiple settings. Although the explanations are thorough, you might consider simplifying some of the longer sentences for enhanced readability. This would help users quickly grasp the functionality without being overwhelmed by lengthy text.
24-298
: General Translation Consistency & Detail
The remaining keys, which cover a wide variety of hacks, settings, and warnings (for example, those related to anti-blind, anti-cactus, arrow damage, AutoEat, and many others), are translated in a clear and descriptive manner. It is recommended to perform a final proofread for minor typographical or stylistic refinements to ensure all messages are uniformly formatted. Also, please confirm that any special formatting (like embedded newline characters and Minecraft-specific color/warning codes) displays correctly in the client.
299-299
: Localization Detail: Key "key.wurst.zoom"
The translation for"key.wurst.zoom"
is simply"Zoom"
. Consider whether a localized Turkish equivalent (such as “Yakınlaştırma”) might provide a better user experience or if it is preferable to retain the technical term as-is for consistency with other language files.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/resources/assets/wurst/translations/tr_tr.json
(1 hunks)src/main/resources/intentionally_untranslated.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/main/resources/intentionally_untranslated.json
🔇 Additional comments (2)
src/main/resources/assets/wurst/translations/tr_tr.json (2)
2-6
: AimAssist Section Consistency
The translations for the AimAssist settings (e.g.,"description.wurst.hack.aimassist"
,"description.wurst.setting.aimassist.fov"
, etc.) are clear and use newline characters effectively where needed. It would be beneficial to double-check that technical terms such as “görüş alanı” are consistent with other language localizations.
17-23
: Anti-AFK Feature Translations
The Anti-AFK related keys deliver clear instructions, and the use of newline separators in the text helps in breaking down the details effectively. Please ensure that terms like “yapay zeka” and the descriptions of movement ranges resonate well with the target audience’s understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/main/resources/assets/wurst/translations/tr_tr.json (2)
2-6
: AimAssist Translations:
The translations for AimAssist are clear and concise. In particular, the explanation for the field-of-view ("Görüş Alanı") is detailed and should be helpful for users.
7-16
: Airplace and AnchorAura Translations:
The entries for Airplace (lines 7–9) and AnchorAura (lines 10–16) are accurately rendered. The descriptions effectively communicate the functionalities, although the AnchorAura text is a bit lengthy—it might benefit from minor language polishing to improve readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/assets/wurst/translations/tr_tr.json
(1 hunks)
🔇 Additional comments (4)
src/main/resources/assets/wurst/translations/tr_tr.json (4)
1-301
: Overall Structure and Syntax:
The JSON file is well-structured, with valid syntax and a comprehensive set of Turkish translations for the various features of the Wurst mod. The file adheres to a clear key–value format, and no syntax issues were detected.
17-23
: AntiAFK Translation Verification:
The AntiAFK description (line 17) states:
"Seni AFK detektörleri tarafından saklamak için rastgele sağa veya sola döndürür."
However, previous feedback indicated that AntiAFK might also include walking or other movements and not just rotational adjustments. Please verify that this translation fully reflects the feature’s behavior.
24-284
: Domain-Specific Terminology and Consistency:
The bulk of the file (lines 24–284) maintains consistent use of technical terms and domain-specific language (including Minecraft color codes and in-game terminology). The translations are comprehensive and align well with expected mod functionality. A review by a native speaker might further refine a few nuanced expressions, but overall, this segment is solid.
285-293
: UI Elements and Warning Messages:
The UI-related messages for AltManager and NoChatReports (lines 285–293) are clearly translated. They accurately capture the necessary warnings and interface instructions. It is worth double-checking that the tone and technical terminology are consistent with the project's style guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/main/resources/assets/wurst/translations/tr_tr.json (4)
17-23
: AntiAFK Translation Clarity
The AntiAFK description (lines 17–23) reads:
"Seni AFK detektörleri tarafından saklamak için rastgele sağa veya sola yürütür."
This phrasing may imply that the feature only moves the player laterally. Please confirm that this accurately reflects the functionality. If the mechanism also involves forward/backward or other directions, it might be beneficial to adjust the wording (for example, using a phrase like “rastgele yönlere doğru hareket ettirir”) so that the full range of behavior is clear to Turkish-speaking users.
75-77
: BuildRandom and Movement Instructions
The BuildRandom swing-hand instruction along with adjacent entries such as Bunnyhop and CameraDistance (lines 75–77) read clearly. A minor nitpick: ensure that phrases like “elini nasıl sallamalıdır” precisely capture the intended in-game animation and are understandable for all users.
81-87
: Chat Translator and ChestESP Details
The ChatTranslator language settings and detection options (lines 81–87) are detailed and precise. A minor suggestion is to double-check formatting elements—such as quotes around names—to ensure they mirror the in-game display.
94-97
: Miscellaneous Movement Feature Translations
The translations for Derp, Dolphin, Excavator, and ExtraElytra (lines 94–97) are correctly phrased. A note for “derp”: the expression “Kafanızı rastgele hareket ettirir” is informal; please ensure this tone is acceptable within the project’s overall style guidelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/assets/wurst/translations/tr_tr.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (13)
src/main/resources/assets/wurst/translations/tr_tr.json (13)
2-9
: AimAssist and Airplace Translations Overview
The translations for AimAssist and Airplace (lines 2–9) are clear and largely accurate, providing concise descriptions of the features and associated UI hints. Please verify that the technical nuances (for example, “Görüş Alanı” and the 360° explanation) align with previous translation standards in the project.
10-16
: Anchoraura Feature Translations
The Anchoraura section (lines 10–16) is well translated with detailed instructions and warnings (e.g. “şarj etme” and “patlatır”). Please double-check that key technical terms are consistent throughout all language files, ensuring that users encounter the same terminology in similar contexts.
24-31
: Anti-Effects Translational Consistency
The translations for AntiBlind, AntiCactus, AntiEntityPush, AntiHunger, AntiKnockback, AntiSpam, AntiWaterPush, and AntiWobble (lines 24–31) are consistent and straightforward. They clearly communicate the intended function and include appropriate warnings.
32-34
: Arrow Damage Feature Details
The Arrow Damage entries (lines 32–34) include technical details (such as the strength value and trident yeet mode warning). Please ensure these values and warnings are up-to-date with the mod’s current behavior and that any numeric limits (like the 10 maximum value) reflect the latest game mechanics.
35-51
: Automated Armor and Eating Features
The section covering AutoArmor, AutoBuild, AutoComplete, AutoDrop, AutoLeave, AutoLibrarian, and AutoEat (lines 35–51) is thorough and detailed. The descriptions include specific thresholds and warnings—which is excellent—but please double-check that all numerical values and conditions truly reflect the game mechanics for consistency with other localization files.
52-57
: Farming and Connection Feature Translations
The entries for Autofarm, Autofish, Automine, AutoPotion, AutoReconnect, and AutoRespawn (lines 52–57) are clear and inform the user about the automated behaviors effectively.
58-74
: Miscellaneous Automated Feature Translations
The translations for Autosign, Autosoup, Autosprint, Autosteal, Autoswim, Autoswitch, Autosword, Autotool, Autototem, Autowalk, BarrierESP, Basefinder, Blink, Boatfly, BonemealAura, BowAimbot, and BuildRandom (lines 58–74) are comprehensive. Please verify that the terminology (especially in warnings and hints) is consistent with similar automated feature descriptions across the project.
78-80
: Camera and CaveFinder Translations
The translations for CameraNoClip, Cavefinder, and the initial ChatTranslator entry (lines 78–80) are expressed in clear technical language. Please verify that the terminology matches other translation files and that any technical instructions (such as those regarding block penetration) remain accurate.
88-90
: ClickGUI, CrashChest, and CreativeFlight Translations
The descriptions for ClickGUI, CrashChest, and CreativeFlight (lines 88–90) include clear instructions along with appropriate warnings. They appear well localized, requiring no further changes.
91-93
: Criticals and CrystalAura Translations
The entries for Criticals, CrystalAura, and its associated swing-hand behavior (lines 91–93) are clearly articulated and maintain consistency with the technical tone seen throughout the file.
98-105
: FastBreak and Flight-Related Feature Translations
The FancyChat, FastBreak, FastLadder, FastPlace, Feedaura, Fightbot, Fish, and Flight features (lines 98–105) include well-defined descriptions and warnings (e.g., regarding NoFall usage for flight). These entries are well localized.
106-107
: Follow Feature – Initial Setup
The translation for the Follow feature (line 106) and its first filter (line 107) is precise. It is important to maintain consistency as the subsequent filter options (in later lines) continue to build on this feature.
1-301
: Overall Turkish Translation File Review
This new Turkish translation file is highly comprehensive and well structured, covering an extensive range of features and settings for the Wurst client. The language used is mostly consistent and includes numerous warnings and guidance texts (e.g., the use of “§c§lUYARI:§r”) that are vital for user awareness. A few minor suggestions have been raised (for instance in the AntiAFK and Derp translations) to further improve clarity and tone. Overall, this addition significantly advances Turkish localization and should enhance the user experience for Turkish-speaking players.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! I'll get this merged in the next feature update.
Description
I added Turkish language for Wurst client.
Testing
References