Fix "show password" icon styles #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renintw
force-pushed
the
fix/show-password-icon-style
branch
from
e9824f4 to
25f95c3
Compare
renintw
force-pushed
the
fix/show-password-icon-style
branch
from
6b0bf4b to
712d3cc
Compare
iandunn
approved these changes
Mar 22, 2023
| cancelCircleFilled, | ||
| check, | ||
| seen, | ||
| unseen, |
There was a problem hiding this comment.
Great job adding the icon to Gutenberg!
I guess we'll need to wait until that's in a stable release to merge this?
There was a problem hiding this comment.
If it is expected to be deployed soon after merging it, then it should wait until the GB 15.5 is released to be merged. Otherwise, it would cause errors.
There was a problem hiding this comment.
Label: [Status] On Hold was added. I'll keep track of the Guteberg release schedule.
There was a problem hiding this comment.
That sounds good 👍🏻 It is usually best to deploy soon after merging.
StevenDufresne
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
This PR fixes
unseenicon provided in the issue has already been added to Gutenberg, and it's expected to be in production on GB 15.5, probably 2-3 weeks later. I've opened another branch that hadunseen.svgincluded so that it can be tested if anyone wants to.lint:js.settings/src/components/password.js, but most of them were just linting updates.Screencasts
Screen.Capture.on.2023-03-22.at.23-24-49.mp4