-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic data/interactions to Password component #33
Conversation
8b48935
to
d95cb3d
Compare
Out of curiosity, why are doing this on the client side? Do we have the same checks on the backend that block weak or compromised passwords? |
Building a custom UI was one of the requirements of the project, since the design of the wp-admin UI in the upstream plugin isn't modern enough. I did initially use the The client does check check the strength, and blocks saving when it's too weak. It's checked with zxcvbn, and we The REST endpoint doesn't check the strength when saving, so somebody could intentionally set a weak password if they really wanted to. But, we do have some backend code in a separate plugin that monitors for weak/compromised passwords, and would force them to reset it. |
While I understand the motivations of doing this only client side, I think it'd be good to also enforce this on the backend, especially if we have already existing code to check for compromised/weak passwords -- it wouldn't be a good UX to set a password via this endpoint, and then later be blocked because it was considered weak or compromised somewhere else. Also, doing this only client side will most likely be reported in our bounty program :) |
👍🏻 , I added backend validation to the endpoint in |
It's worth noting that WordPress core / wp-admin doesn't do this, you can set any password as all the validation is client-side. As a result, we'll have to disable the admin UIs, I've opened #37 to track that. |
Fixes #27