Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revalidation: Don't prompt on non-2fa sessions #168

Merged
merged 1 commit into from
May 19, 2023

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 19, 2023

While reviewing #161 (which this doesn't replace, but this does resolve one underlying issue for) I realised that part of the API changed during development.

This API field is attached to all users, but reflects the current user session, not the user object, AND when the user isn't using a 2FA session, it returns invalid data that should have never been returned.

Ie. { revalidate_url: ..., expires_at: 600 } shouldn't be returned here, instead the code previously expected false.

See #160 #161

…e current user, document why, and return false for a non-2fa session.
@dd32 dd32 merged commit d5a28af into trunk May 19, 2023
@dd32 dd32 deleted the 160-2fa-revalidate-prompt branch May 19, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant