Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Backup Codes UI until primary provider enabled #157

Merged
merged 2 commits into from
May 16, 2023
Merged

Disable Backup Codes UI until primary provider enabled #157

merged 2 commits into from
May 16, 2023

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented May 11, 2023 •
edited
Loading

Fixes #47

This disables the Backup Codes UI when the user hasn't enabled TOTP yet. In the future, WebAuthn can be included so that any primary provider is acceptable, rather than TOTP specifically.

Related #158 -- The UI will show Backup Codes as enabled when TOTP is disabled, but the root cause for that is outside the scope of this PR

@iandunn iandunn mentioned this pull request May 11, 2023
Closed
@iandunn iandunn force-pushed the disable-backup-ui branch from 2941d5a to 9973b5f Compare May 11, 2023 22:40
@iandunn iandunn self-assigned this May 11, 2023
@iandunn iandunn added this to the Iteration 1 milestone May 11, 2023
@iandunn iandunn requested a review from adamwoodnz May 11, 2023 22:47
@iandunn iandunn marked this pull request as ready for review May 11, 2023 22:47
@iandunn iandunn requested a review from StevenDufresne May 11, 2023 22:47
@iandunn iandunn modified the milestones: Iteration 1, MVP May 11, 2023
adamwoodnz
adamwoodnz reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've previously had 2FA and backup codes enabled, but now I've disabled 2FA, should I still be able to access backup codes? I expected the logic to be based on 2FA being enabled

Screen Shot 2023-05-12 at 2 45 15 PM

@adamwoodnz adamwoodnz mentioned this pull request May 12, 2023
Merged
@iandunn
Copy link
Member Author

iandunn commented May 12, 2023

now I've disabled 2FA, should I still be able to access backup codes?

No, but that felt outside the scope of this PR. I opened #158 for it.

@iandunn iandunn force-pushed the disable-backup-ui branch from d6af8b0 to 747921c Compare May 12, 2023 16:30
iandunn added 2 commits May 16, 2023 10:56
@iandunn
ESLint: Set root: true to bypass fallback configs.
ada5579 
Otherwise a generic `.eslintrc.js` might be loaded in some environments.

> By default, ESLint looks for configuration files in all parent folders up to the root directory. This can be useful if you want all of your projects to follow a certain convention, but can sometimes lead to unexpected results.
> https://eslint.org/docs/latest/use/configure/configuration-files#cascading-and-hierarchy
@iandunn
Disable Backup Codes UI until primary provider enabled
aac2fab
@iandunn iandunn force-pushed the disable-backup-ui branch from becdb2c to aac2fab Compare May 16, 2023 17:56
@iandunn iandunn merged commit 7139254 into trunk May 16, 2023
@iandunn iandunn deleted the disable-backup-ui branch May 16, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwoodnz adamwoodnz adamwoodnz left review comments

@StevenDufresne StevenDufresne StevenDufresne left review comments

Assignees

@iandunn iandunn

Labels
None yet
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Disable backup codes UI until primary provider enabled
3 participants
@iandunn @adamwoodnz @StevenDufresne