Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB-backed WP_Session_Tokens implementation #345

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 23, 2023

WordPress sessions (Which are not used on WordPress.org currently) use user-meta to store active user sessions.

This class, based on the implementation on WordPress.com, stores these sessions in a custom table.

This is pending changes to allow the use of sessions on WordPress.org, such as dealing with Trac and the Codex the codex doesn't share cookies, only user tables..

This is preferably needed so that we can use the upstream 2fa session code for WordPress/wporg-two-factor#43

@dd32 dd32 marked this pull request as ready for review February 23, 2023 08:31
@dd32
Copy link
Member Author

dd32 commented Feb 24, 2023

Draft support for this in the TracWordPressCookiesPlugin: dd32/TracWordPressCookiesPlugin#2 - I haven't tested this in my test trac environment, but it looks like it'll work and is much simpler than the user_meta implementation.

@dd32 dd32 merged commit 4394d06 into trunk Feb 24, 2023
@dd32 dd32 deleted the add/session-manager branch February 24, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant