Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORS Proxy] Support chunked encoding when running in Apache/Nginx/etc #2114

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+12 −3
Open

[CORS Proxy] Support chunked encoding when running in Apache/Nginx/etc #2114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/playground/php-cors-proxy/cors-proxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,16 @@

function send_response_chunk($data) {
global $is_chunked_response;
if ($is_chunked_response) {
if ($is_chunked_response && php_sapi_name() === 'cli-server') {
// We need to manually chunk the response when running in the PHP
// built-in server. It won't handle that for us.
echo sprintf("%s\r\n%s\r\n", dechex(strlen($data)), $data);
} else {
// When running behing an Apache or Nginx or another webserver,
// it will handle the chunking for us. Manually sending the chunk
// header, \r\n separator, body, and \r\n trailer isn't just
// unnecessary, but it would actually include those bytes in the
// response body.
echo $data;
}
@ob_flush();
Expand Down Expand Up @@ -255,7 +262,9 @@ function(
// Close cURL session
curl_close($ch);

// Only send chunked transfer encoding footer if we're using chunked encoding
if ($is_chunked_response) {
// Only send chunked transfer encoding footer if we're using chunked encoding.
// We need to manually send the footer when running in the PHP built-in server
// because, unlike apache or nginx, it won't handle that for us.
if ($is_chunked_response && php_sapi_name() === 'cli-server') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to add this under the code review response...

nit: The terms of this condition are used in multiple places. Maybe it would be good to capture it in a function like should_send_as_chunked_response().

echo "0\r\n\r\n";
}
Loading