Build @php-wasm packages as dual ESM + CJS
#2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
adamziel
changed the title
@php-wasm packages
adamziel
changed the title
@php-wasm packages@php-wasm packages as dual ESM + CJS
adamziel
changed the title
@php-wasm packages as dual ESM + CJS@php-wasm packages as dual ESM + CJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Ships CommonJS files alongside ES Modules files for the following packages:
@php-wasm/web-service-worker@php-wasm/util@php-wasm/scopesThis resolves Node.js import errors reported in #2086.
Closes #2086
Implementation details
I broke those imports in c6b4f4a by creating a dependency between @wp-playground/blueprints and @php-wasm/web-service-worker. The latter package is only built as ESModules and doesn't ship any commonjs files expected by Node.js.
Testing Instructions (or ideally a Blueprint)
@php-wasm/web-service-workerin Node.js to confirm the fix worked