Twenty Twenty-Five: Update text strings #8314
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| @@ -39,7 +39,7 @@ | |||
| <div class="wp-block-buttons"> | |||
| <!-- wp:button --> | |||
| <div class="wp-block-button"> | |||
| <a class="wp-block-button__link wp-element-button"><?php echo esc_html_x( 'Learn More', 'Button text of intro section.', 'twentytwentyfive' ); ?></a> | |||
| <a class="wp-block-button__link wp-element-button"><?php esc_html_e( 'Learn More', 'twentytwentyfive' ); ?></a> | |||
There was a problem hiding this comment.
Using 'Learn More' in the banner-intro-image and hero-full-width-image patterns would make them consistent with each other, but the existing string in cta-centered-heading has a lowercase m:
There was a problem hiding this comment.
Yes let's use sentence case here :)
| @@ -23,7 +23,7 @@ | |||
| <!-- /wp:heading --> | |||
|
|
|||
| <!-- wp:paragraph {"fontSize":"medium"} --> | |||
| <p class="has-medium-font-size"><?php echo esc_html_x( 'This exquisite compilation showcases a diverse array of photographs that capture the essence of different eras and cultures, reflecting the unique styles and perspectives of each artist. Fleckenstein’s evocative imagery, Strand’s groundbreaking modernist approach, and Kōno’s meticulous documentation of Japanese life come together in a harmonious blend that celebrates the art of photography. Each image in “The Stories Book” is accompanied by insightful commentary, providing historical context and revealing the stories behind the photographs. This collection is not only a visual feast but also a tribute to the power of photography to preserve and narrate the multifaceted experiences of humanity.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p> | |||
| <p class="has-medium-font-size"><?php echo esc_html_x( 'This exquisite compilation showcases a diverse array of photographs that capture the essence of different eras and cultures, reflecting the unique styles and perspectives of each artist. Fleckenstein\'s evocative imagery, Strand\'s groundbreaking modernist approach, and Kōno\'s meticulous documentation of Japanese life come together in a harmonious blend that celebrates the art of photography. Each image in "The Stories Book" is accompanied by insightful commentary, providing historical context and revealing the stories behind the photographs. This collection is not only a visual feast but also a tribute to the power of photography to preserve and narrate the multifaceted experiences of humanity.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p> | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use a curly one? I mean: ’
There was a problem hiding this comment.
The guidelines says that it should be straight:
https://make.wordpress.org/docs/style-guide/punctuation/apostrophes/
I don't feel strongly for or against, I believe it was Peter W that pointed out that it was not following the guidelines. I would have to look through Slack to find the exact comment.
I looked at the translation tool used in the project, as well as an old version of Poedit, and the escaping is not even visible in the strings. What is the problem translators are experiencing? Where is this practice documented?
There was a problem hiding this comment.
It might be good to revisit this discussion in the future, but I would prefer not to edit the apostrophes in these strings when they have already been translated.
Yes, Peter pointed to the documentation style guide in a Slack thread, but that does not exactly fit text strings. Core often uses the HTML entities ’, “, and ” for single-quote apostrophes and curly quotes (probably "for better typography," and "Translators can use actual characters instead of entities").
In themes:
- Twenty Twenty and TT1 have the
“, and”entities in starter content block patterns. - In addition to TT5, both Twenty Sixteen and TT4 have
“ ”curly quote characters in their patterns.
Side note: The straight quotes on the documentation handbook pages run through a content filter that replaces them with curly quote entities.
There was a problem hiding this comment.
Then lets close this PR, because it would take longer to go through this PR again than to start over and just not include the changes in the first place.
There was a problem hiding this comment.
I can't do it today :) Because, I need to have a weekend 😄
| @@ -39,7 +39,7 @@ | |||
| <div class="wp-block-buttons"> | |||
| <!-- wp:button --> | |||
| <div class="wp-block-button"> | |||
| <a class="wp-block-button__link wp-element-button"><?php echo esc_html_x( 'Learn More', 'Button text of intro section.', 'twentytwentyfive' ); ?></a> | |||
| <a class="wp-block-button__link wp-element-button"><?php esc_html_e( 'Learn More', 'twentytwentyfive' ); ?></a> | |||
There was a problem hiding this comment.
Yes let's use sentence case here :)
| @@ -25,7 +25,7 @@ | |||
| <?php | |||
| echo wp_kses_post( | |||
| /* translators: This string contains the word "Stories" in four different languages with the first item in the locale's language. */ | |||
| _x( '“Stories, <span lang="es">historias</span>, <span lang="uk">iсторії</span>, <span lang="el">iστορίες</span>”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) | |||
| _x( '"Stories, <span lang="es">historias</span>, <span lang="uk">iсторії</span>, <span lang="el">iστορίες</span>"', 'Placeholder heading in four languages.', 'twentytwentyfive' ) | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use a curly one?
| @@ -48,7 +48,7 @@ | |||
| <!-- wp:column {"verticalAlignment":"bottom","width":"80%"} --> | |||
| <div class="wp-block-column is-vertically-aligned-bottom" style="flex-basis:80%"> | |||
| <!-- wp:heading {"textAlign":"left","align":"wide","style":{"typography":{"lineHeight":"0.9","fontStyle":"normal","fontWeight":"300"}},"fontSize":"xx-large"} --> | |||
| <h2 class="wp-block-heading alignwide has-text-align-left has-xx-large-font-size" style="font-style:normal;font-weight:300;line-height:0.9"><?php esc_html_e( 'Let’s hear them.', 'twentytwentyfive' ); ?></h2> | |||
| <h2 class="wp-block-heading alignwide has-text-align-left has-xx-large-font-size" style="font-style:normal;font-weight:300;line-height:0.9"><?php esc_html_e( 'Let\'s hear them.', 'twentytwentyfive' ); ?></h2> | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use the curly one?
| @@ -86,7 +86,7 @@ | |||
| <!-- wp:group {"style":{"spacing":{"blockGap":"var:preset|spacing|20"}},"layout":{"type":"flex","orientation":"vertical","justifyContent":"stretch"}} --> | |||
| <div class="wp-block-group"> | |||
| <!-- wp:heading {"level":4} --> | |||
| <h4 class="wp-block-heading"><a href="#"><?php esc_html_e( 'Things you didn’t know about the deep ocean', 'twentytwentyfive' ); ?></a></h4> | |||
| <h4 class="wp-block-heading"><a href="#"><?php esc_html_e( 'Things you didn\'t know about the deep ocean', 'twentytwentyfive' ); ?></a></h4> | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use the curly one?
| @@ -28,7 +28,7 @@ | |||
| <h2 class="wp-block-heading has-text-align-left" style="font-size:22rem;font-style:normal;font-weight:300;letter-spacing:-0.03em;line-height:1.4"><?php echo esc_html_x( 'Hey,', 'Example heading in pattern.', 'twentytwentyfive' ); ?></h2> | |||
| <!-- /wp:heading --> | |||
| <!-- wp:paragraph {"className":"is-style-text-subtitle"} --> | |||
| <p class="is-style-text-subtitle"><?php echo esc_html_x( 'My name is Nora Winslow Keene, and I’m a committed public interest attorney. Living in Denver, Colorado, I’ve spent years championing the rights of underrepresented workers. A graduate of Stanford University, I played a key role in securing critical protections for agricultural laborers, ensuring better wages and access to healthcare. My work has focused on advocating for environmental justice and improving the quality of life for rural communities. Every case I take on is driven by the belief that everyone deserves dignity and fair treatment in the workplace.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p> | |||
| <p class="is-style-text-subtitle"><?php echo esc_html_x( 'My name is Nora Winslow Keene, and I\'m a committed public interest attorney. Living in Denver, Colorado, I\'ve spent years championing the rights of underrepresented workers. A graduate of Stanford University, I played a key role in securing critical protections for agricultural laborers, ensuring better wages and access to healthcare. My work has focused on advocating for environmental justice and improving the quality of life for rural communities. Every case I take on is driven by the belief that everyone deserves dignity and fair treatment in the workplace.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p> | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use the curly one?
| @@ -35,7 +35,7 @@ | |||
| <!-- /wp:heading --> | |||
|
|
|||
| <!-- wp:paragraph --> | |||
| <p><?php echo esc_html_x( 'I’m Nora, a dedicated public interest attorney based in Denver. I’m a graduate of Stanford University.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p> | |||
| <p><?php echo esc_html_x( 'I\'m Nora, a dedicated public interest attorney based in Denver. I\'m a graduate of Stanford University.', 'Pattern placeholder text.', 'twentytwentyfive' ); ?></p> | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use the curly one?
| @@ -39,7 +39,7 @@ | |||
| <!-- wp:group {"style":{"dimensions":{"minHeight":"100%"}},"layout":{"type":"flex","orientation":"vertical","verticalAlignment":"space-between","flexWrap":"nowrap","justifyContent":"stretch"}} --> | |||
| <div class="wp-block-group" style="min-height:100%"> | |||
| <!-- wp:paragraph {"align":"left","style":{"typography":{"lineHeight":"1.2"}},"fontSize":"x-large"} --> | |||
| <p class="has-text-align-left has-x-large-font-size" style="line-height:1.2"><?php esc_html_e( 'I’m Asahachi Kōno, a Japanese photographer, a member of Los Angeles’s Japanese Camera Pictorialists of California. Before returning to Japan, I worked as a photo retoucher.', 'twentytwentyfive' ); ?></p> | |||
| <p class="has-text-align-left has-x-large-font-size" style="line-height:1.2"><?php esc_html_e( 'I\'m Asahachi Kōno, a Japanese photographer, a member of Los Angeles\'s Japanese Camera Pictorialists of California. Before returning to Japan, I worked as a photo retoucher.', 'twentytwentyfive' ); ?></p> | |||
There was a problem hiding this comment.
Instead of escaping a straight apostrophe, could we use the curly one?
In Twenty Twenty-Five:
Title: Text-only blog, homeis nowTitle: Text blog hometo matchTitle: News blog homeetc.Trac ticket: https://core.trac.wordpress.org/ticket/62482
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.