HTML API: Simplify the class_list loop #8076
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplification and optimization of the class_list loop based on some work in #7857.
The important change here is that the position (
$at
) advances past any whitespace characters before the while condition is checked. The loop never begins at whitespace characters allowing for a few checks to be eliminated and the overall loop logic to be simplificed. Whitespace is skipped before the loop is entered and when$at
is adjusted at the end of the loop.This allows for some conditionals to be removed from the loop because they become invariants. The loop is always exited by the
while
condition after the entire string has been processed.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.