Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background-repeat to safe_style_css #5814

Conversation

andrewserong
Copy link
Contributor

This PR adds the background-repeat property to safe_style_css to support the missing background repeat property.

This is a prerequisite for adding in a background-repeat toggle to the background image support feature, which has landed in Gutenberg in: WordPress/gutenberg#57005

Note: that PR includes other PHP changes that will be backported separately, so that this PR can just focus on the proposed change to kses.php and its tests.

To test, ensure the tests pass, or if you're using the Docker environment for wordpress-develop, run the following locally: npm run test:php /var/www/tests/phpunit/tests/kses.php

Trac ticket: https://core.trac.wordpress.org/ticket/60132


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests.

The tests passed.

👍🏻

@andrewserong
Copy link
Contributor Author

Thanks for giving this a quick look! I forgot to add the ticket number to the test that uses this data provider. Added in 5fc84d2

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r57228.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants