Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.yml #665

Closed
wants to merge 1 commit into from
Closed

Update test.yml #665

wants to merge 1 commit into from

Conversation

BrookeDot
Copy link
Contributor

What?

This PR updates the tests to:

  • Add PHP 8.4
  • Update builds to 8.3

Why?

This should help ensure that the plugin works well with PHP 8.4 moving forward and ensure that the tests work better on a slightly updated PHP version 8.3.

How?

Manually edits the test file.

Changelog Entry

Changed - Update tests to include PHP 8.4

- Adds PHP 8.4
- Updates builds to 8.3
Copy link
Collaborator

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@kasparsd
Copy link
Collaborator

Error while running docker compose command.
failed to solve: wordpress:php8.4: failed to resolve source metadata for docker.io/library/wordpress:php8.4: docker.io/library/wordpress:php8.4: not found

Looks like there is a known issue with missing 8.4 docker-library/wordpress#932

@BrookeDot
Copy link
Contributor Author

Closing this for now as the WordPress docker doesn't support 8.4 yet, so we'll have to wait or switch repos.

@BrookeDot BrookeDot closed this Feb 13, 2025
@BrookeDot
Copy link
Contributor Author

I'll follow that issue and re-open once PHP 8.4 support is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants