Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Action unit testing #624

Merged
merged 51 commits into from
Aug 22, 2024
Merged

Fix Action unit testing #624

merged 51 commits into from
Aug 22, 2024

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Aug 20, 2024 •
edited
Loading

What?

This PRs history is a fair bit of a mess, but in short it:

Why?

Because GitHub actions have been broken for far too long.

How?

Even I'm not sure I totally understand how.

Testing Instructions

Just don't. The commit history should show even I don't know what I'm doing.

Screenshots or screencast

Changelog Entry

Changed - Improved unit testing coverage with WordPress & PHP versions.

dd32 added 30 commits August 20, 2024 16:16
@dd32
Use composer within the cli container.
aabc430
@dd32
Update wp-env.
a559553
@dd32
Update the node requirement to 18.
d5e063f
@dd32
Update composer
47ec21f
@dd32
Update wp-env, again.
ecd9700
@dd32
Try running phpunit via the container.
021d4ad
@dd32
Try running phpunit via the container.
39f6787
@dd32
PHP 7.2
5b93961
@dd32
rm local wordpress checkout.
49708b1
@dd32
rm wordpress
cb7bff9
@dd32
update composer
efeceaa
@dd32
Import tests_add_filter() via the same method as Gutenberg: https://g…
4ca7561 
…ithub.com/WordPress/gutenberg/blob/9c9f6535cdc3cd57a3b8583ea6292a2c90552ab3/phpunit/bootstrap.php#L41
@dd32
update composer
a35efa5
@dd32
update
50860b8
@dd32
update packages
3c6dd03
@dd32
Split test into multiple jobs
f0c8a62
@dd32
Drop PHP 7.2 test for now, wp-env doesn't seem to install the proper …
f747f9f 
…phpunit for that
@dd32
disable wp_redirect()
bf98ce5
@dd32
Fix email sending.
04a9562
@dd32
Don't need to override wp_redirect, the PHP warnings don't cause a fa…
ccea551 
…ilure.
@dd32
Updates
3369165
@dd32
Restore PHP 7.2
d2c69cf
@dd32
Add PHP 8.3
70fc5ba
@dd32
Don't need to be compatible with PHP 5.6
c349634
@dd32
add trunk, include versions.
cb4042f
@dd32
PHP 7.2+ for compat
51591d6
@dd32
Reverse order of PHP's
0e9c133
@dd32
Fix Build
9c5d059
@dd32
Revert the parse-gitignore package back to 0.5.1, v1 and v2 don't wor…
939b4eb 
…k the same way.
@dd32
Restore the phpunit-watcher
c913c1c
@dd32
Copy link
Member Author

dd32 commented Aug 20, 2024 •
edited
Loading

Pretty sure I've broken the build script, dist/includes/qrcode-generator/ contains all the library files and dist/includes/qrcode.js exists, which should be at dist/includes/qrcode-generator/qrcode.js.

That build script should be replaced with something not-grunt I suspect. I broke it locally only.

@dd32 dd32 changed the title Fix the unit testing Fix Action unit testing Aug 21, 2024
@dd32 dd32 merged commit 53042aa into WordPress:master Aug 22, 2024
24 checks passed
@dd32 dd32 added this to the 0.10.0 milestone Aug 22, 2024
@kasparsd kasparsd mentioned this pull request Sep 18, 2024
Merged
@jeffpaul jeffpaul modified the milestones: 0.11.0, 0.10.0 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Tests should run against WordPress stable and WordPress trunk, and supported PHP versions
2 participants
@dd32 @jeffpaul