Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release version 0.8.2 #570

Closed
wants to merge 6 commits into from
Closed

Release version 0.8.2 #570

wants to merge 6 commits into from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 22, 2023 •
edited by iandunn
Loading

Some issues have been identified since 0.8 + 0.8.1 was released, 0.9.0 is a little ways off still so let's release 0.8.2 to resolve those issues for now:

Release instructions

  • Branch: Starting from tags/0.8.1, create a branch named release/0.8.2 for the release-related changes.
  • Version bump: Bump the version number in readme.txt and two-factor.php if it does not already reflect the version being released. Update both the plugin "Version:" header value and the plugin TWO_FACTOR_VERSION constant in two-factor.php.
  • Changelog: Add/update the changelog in readme.txt.
  • New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
  • Readme updates: Make any other readme changes as necessary. readme.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
  • Create Release PR: Push any local changes in release/0.8.2 to origin, create a release PR, and request review to ensure all CI checks pass and ensure master branch changes are limited to merges only.
  • Merge: After review approval, merge the release pull request (or make a non-fast-forward merge from your release branch to master). master contains the latest stable release.
  • Release: Create a new release, naming the tag and the release with the new version number, and targeting the release/0.8.2 branch. Paste the changelog from readme.txt into the body of the release and include a link to the closed items on the milestone.
  • SVN: Wait for the GitHub Action: Deploy to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
  • Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/two-factor/. This may take a few minutes.
  • Mark any included PRs / Issues as 0.8.2 from 0.9.0 if appropriate
  • Close the milestone: Edit the milestone with the release date (in the Due date (optional) field) and link to the GitHub release (in the Description field), then close the milestone.
  • Punt incomplete items: If any open issues or PRs which were milestoned for 0.8.2 do not make it into the release, update their milestone to 0.9.0 or Future Release.`
  • Cherry pick the version bump commit to master -- Bump version identifier #588

dd32 and others added 5 commits May 22, 2023 11:52
@dd32
Bump version identifier
30e3d1f
@dd32
Enqueue jQuery and wp.apiRequest for use within callbacks. (#561)
d971a9d
@spenserhale @dd32
Use the integer REST API type instead of number, to resolve overly st…
441690f 
…rict user_id capability checks (#560)

* Fixing bug where Super Admins cannot setup Time Based One-Time Password as first Two Factor option on WP VIP
* refactor(Two_Factor_Backup_Codes): setting user_id type to integer instead of number to make consistent with Two_Factor_Totp

Fixes #559
Fixes #557
@av3nger @dd32
Bump tested up to version (#552)
af7ad52
@dd32
Tests: Simplify the cookie management.
286aa22 
See #528
@dd32 dd32 added this to the 0.8.2 milestone May 22, 2023
@jeffpaul
Copy link
Member

Looks like this pulls in part of #528, namely the tests but not the functional change to class-two-factor-core.php. Assuming that was on purpose @dd32?

@jeffpaul jeffpaul self-requested a review June 1, 2023 13:42
jeffpaul
jeffpaul approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the 👍🏼 on #570 (comment), I'm going to approve this as good... thanks for handling the release @dd32!

@iandunn
Copy link
Member

iandunn commented Jun 1, 2023

Should we include #575 here too @dd32 ?

@iandunn
Copy link
Member

iandunn commented Jun 1, 2023

Er, nevermind, it looks like #529 isn't slated until 0.9.0, so #575 doesn't apply 👍🏻

@shaunek-hero
Copy link

Hi I'm just and observer and a happy user of this fine plugin, but wondering when this 0.8.2 might be approved and released? I've had some complaints about #557 and I have applied the appropriate fix on my own WP instances but would would love to see this release out, assuming it is ready to go.

@dd32 dd32 mentioned this pull request Aug 7, 2023
Closed
@iandunn iandunn mentioned this pull request Sep 4, 2023
Merged
@iandunn
Copy link
Member

iandunn commented Sep 4, 2023

This has been released now:

Closing this PR since this isn't intended to be merged to the main branch.

@iandunn iandunn closed this Sep 4, 2023
@kasparsd kasparsd deleted the release/0.8.2 branch April 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@dd32 dd32

Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
6 participants
@dd32 @jeffpaul @iandunn @shaunek-hero @spenserhale @av3nger