Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary opacity override for Firefox placeholders #69312

Merged
merged 4 commits into from
Feb 27, 2025
+1 −5
Merged

Remove unnecessary opacity override for Firefox placeholders #69312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87c2efb
Remove unnecessary opacity override for Firefox placeholders
himanshupathak95 Feb 25, 2025
6c8e770
Merge branch 'trunk' into fix/remove-moz-placeholder-opacity
himanshupathak95 Feb 25, 2025
8b6eeb0
Changelog: Add entry for TextareaControl
himanshupathak95 Feb 25, 2025
cfef6e7
Move changelog entry under the Enhancement section.
afercia Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/base-styles/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@
}

&::-moz-placeholder {
opacity: 1; // Necessary because Firefox reduces this from 1.
color: $dark-gray-placeholder;
}

Expand Down
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

### Enhancement

- `TextareaControl`: Fix Firefox placeholder text opacity override ([#69312](https://github.com/WordPress/gutenberg/pull/69312)).
- `BorderControlDropdown`, `BorderControl`: Reset button is always visible. ([#69066](https://github.com/WordPress/gutenberg/pull/69066)).

### Internal
Expand Down
2 changes: 0 additions & 2 deletions packages/components/src/textarea-control/styles/textarea-control-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export const StyledTextarea = styled.textarea`
}
&::-moz-placeholder {
opacity: 1; // Necessary because Firefox reduces this from 1.
color: ${ COLORS.ui.darkGrayPlaceholder };
}
Expand All @@ -76,7 +75,6 @@ export const StyledTextarea = styled.textarea`
}
&::-moz-placeholder {
opacity: 1; // Necessary because Firefox reduces this from 1.
color: ${ COLORS.ui.lightGrayPlaceholder };
}
Expand Down
2 changes: 0 additions & 2 deletions packages/editor/src/components/post-text-editor/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ textarea.editor-post-text-editor {

&::-moz-placeholder {
color: $dark-gray-placeholder;
// Override Firefox default.
opacity: 1;
}

&:-ms-input-placeholder {
Expand Down
Loading