Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Add e2e test for 404 page #69272

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Test: Add e2e test for 404 page #69272

merged 3 commits into from
Feb 25, 2025

Conversation

Infinite-Null
Copy link
Contributor

Related to: #69234 (comment)
PR: #69234

What?

Add E2E test for 404 page in the Site Editor

Why?

This PR adds coverage for 404 page in the Site Editor.

Testing Instructions

  1. Run E2E tests for the site-editor:
npm run test:e2e:debug -- test/e2e/specs/site-editor/navigation.spec.js
  1. Verify the new 404 test passes

Screenshots:

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,
I've added the E2E test for the 404 page in the Site Editor. Please review it at your convenience.
Thank You!

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 23, 2025
@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,
Thank you for the feedback! I have implemented the changes. Please review it at your convenience.

t-hamano
t-hamano approved these changes Feb 24, 2025
View reviewed changes
@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano and @Mamaduka,
I have updated the PR and removed the await admin.visitSiteEditor();.
Please review it at your convenience.
Thank You!

@t-hamano t-hamano merged commit 9a495f8 into WordPress:trunk Feb 25, 2025
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.4 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@t-hamano t-hamano Awaiting requested review from t-hamano

Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 20.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Infinite-Null @Mamaduka @t-hamano