Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Missing Double Quote in Number Control #69207

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Feb 15, 2025

What?

Added Missing double quote in input type number

Why?

input[type="number] double quote is missing here.

Ref: https://developer.wordpress.org/block-editor/reference-guides/components/number-control/

How?

Added Missing double quote input[type="number"]

Testing Instructions

  1. Open packages/components/src/number-control/README.md file
  2. See Error

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Feb 15, 2025
@shail-mehta shail-mehta self-assigned this Feb 15, 2025
Copy link

Flaky tests detected in 1c72cb0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13346926929
📝 Reported issues:

@shail-mehta shail-mehta marked this pull request as ready for review February 15, 2025 17:22
Copy link

github-actions bot commented Feb 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta requested a review from t-hamano February 15, 2025 17:23
@shail-mehta
Copy link
Member Author

I'm not sure if it needs to be changed in the core as well? Because I didn’t get the correct path of this file in core.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

if it needs to be changed in the core

This file does not need to be backported to core.

@t-hamano t-hamano added the [Package] Components /packages/components label Feb 17, 2025
@t-hamano t-hamano merged commit ac992f7 into trunk Feb 17, 2025
71 of 72 checks passed
@t-hamano t-hamano deleted the fix-syntax-issue-in-number-control branch February 17, 2025 01:54
@github-actions github-actions bot added this to the Gutenberg 20.4 milestone Feb 17, 2025
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants