Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Control: Remove mobile-specific font size override in input controls #69114

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Feb 10, 2025

What?

Closes: #69113

Removes mobile-specific font size override in input controls to maintain consistent typography across screen sizes.

Why?

Currently, there's an inconsistency in font sizes on mobile screens where the selected text in custom select controls appears at 16px while other elements remain at 13px. This creates:

  • Visual disruption in typography hierarchy
  • Inconsistency between selected text (16px) and dropdown options (13px)
  • Unnecessary variation from other form controls and text elements

Testing Instructions

  • Open any page/post with a custom select control (e.g., the Typography panel in the block editor)
  • View the page at mobile width (below 600px)
  • Verify that:
    • The selected text in dropdowns is now 13px (consistent with other elements)
    • The dropdown options remain at 13px
    • The text appears visually consistent with other form controls

Screencast

Before

Screen.Recording.2025-02-10.at.13.15.06.mov

After

Screen.Recording.2025-02-10.at.13.31.50.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected font size for custom select control on mobile screens
2 participants