Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberControl: Fix invalid HTML attributes for infinite bounds #69033

Merged
merged 7 commits into from
Feb 13, 2025
Merged

NumberControl: Fix invalid HTML attributes for infinite bounds #69033

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4602271
NumberControl: Fix invalid HTML attributes for infinite bounds
Infinite-Null Feb 4, 2025
4a6c455
NumberControl: Maintain prop order
Infinite-Null Feb 5, 2025
f8301c4
Add `CHANGELOG.md` entry
Infinite-Null Feb 12, 2025
90b0591
Merge branch 'trunk' into fix/number-control-infinity-attributes
Infinite-Null Feb 12, 2025
d4d17c8
Format `NumberControl` changelog entry
Infinite-Null Feb 12, 2025
f26c7b0
Merge branch 'trunk' into fix/number-control-infinity-attributes
Infinite-Null Feb 12, 2025
952ed62
Merge branch 'trunk' into fix/number-control-infinity-attributes
Infinite-Null Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/src/number-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ function UnforwardedNumberControl(
hideHTMLArrows={ spinControls !== 'native' }
isDragEnabled={ isDragEnabled }
label={ label }
max={ max }
min={ min }
min={ min === -Infinity ? undefined : min }
max={ max === Infinity ? undefined : max }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prop position changed? Can you please update to use max first and min later?

Copy link
Contributor Author

@Infinite-Null Infinite-Null Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback, I've updated the PR to maintain consistent prop ordering.

ref={ mergedRef }
required={ required }
step={ step }
Expand Down
Loading