Remove non translatable additional info from font size picker visual label and improve labeling #69011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -186 B (-0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 69594a1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13137700177
|
6 tasks
|
@im3dabasia when you have a chance, I'd appreciate your thoughts on this alternative approach to #68826 thanks! |
afercia
force-pushed
the
try/font-size-picker-remove-headerhint
branch
from
69594a1 to
d161821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63810
Alternative to #68826
What?
Closes
For all the font size picker 3 variants (ToggleGroup, CustomSelectControl and Custom size UnitControl + RangeControl), the component visual labeling is made of visibel text 'Size' and some additional textual info e.g. the selected size, or the font size unit or a hardcoded string 'Custom'. Noting the component also uses a
fieldsetelement with a visually hiddenlegendthat make the labeling of the entire group and controls a little noisy.This string is not fully translatable because it's just concatenated with the string 'Size'. Also, I'd argue the additional info doesn't add great value because:
Customis unnecessary because users do know they switched the UI to st a custom size.Why?
How?
headerHintadditional info from the visual label.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: