Navigation Link Block: Use stable variable for underline color styling #68953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshupathak95
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@t-hamano I have updated the variable and tested the changes. I think this PR is ready to be shipped. Thanks for the suggestion 😇 |
t-hamano
added
[Type] Code Quality
t-hamano
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
LGTM!
Just to be sure, here's how much the colors will change with this PR.
- Color on the left (trunk): The red color defined in
--wp--preset--color--vivid-red, that is, the default theme.json. - Color on the right (This PR): The red color defined by the
$alert-redvariable in thebase-stylespackage.
t-hamano
added
the
props-bot
github-actions
bot
removed
the
props-bot
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
…ordPress#68953) Co-authored-by: himanshupathak95 <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of: #68628
Related: #68628 (comment)
What?
Updates the navigation link block's invalid/draft state underline color to use an SCSS variable.
Why?
To maintain consistency with Gutenberg's color system and improve maintainability.
Testing Instructions
Screenshots